Messages in this thread | | | Date | Tue, 1 Oct 2019 18:14:13 +0100 | From | Will Deacon <> | Subject | Re: [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC |
| |
On Tue, Oct 01, 2019 at 10:12:59AM -0700, Nick Desaulniers wrote: > On Tue, Oct 1, 2019 at 10:08 AM Will Deacon <will@kernel.org> wrote: > > > > On Tue, Oct 01, 2019 at 09:59:43AM -0700, Nick Desaulniers wrote: > > > On Tue, Oct 1, 2019 at 9:47 AM Will Deacon <will@kernel.org> wrote: > > > > > > > > On Tue, Oct 01, 2019 at 04:30:56PM +0100, Catalin Marinas wrote: > > > > > In the long run, I wouldn't mandate CROSS_COMPILE_COMPAT to always be > > > > > set for the compat vDSO since with clang we could use the same compiler > > > > > binary for both native and compat (with different flags). That's once we > > > > > cleaned up the headers. > > > > > > > > But we'll still need it even with clang so that the relevant triple can be > > > > passed to the --target option. The top-level Makefile already does this: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Makefile#n544 > > > > > > That's not pulling the cross compiler out of a *config* (as this patch > > > is proposing); rather from an env var. > > > > CROSS_COMPILE_COMPAT is the environment variable, right? If not, then I have > > my terminology mixed up. > > Ah, sorry, I'm the one misreading the patch. I thought the commit > message was showing what the new process would be. I see now that it's > describing the issue pre-patch. My mistake.
Thanks. Thought I was losing the plot for a moment there!
Will
| |