lkml.org 
[lkml]   [2019]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC
    On Tue, Oct 1, 2019 at 9:47 AM Will Deacon <will@kernel.org> wrote:
    >
    > On Tue, Oct 01, 2019 at 04:30:56PM +0100, Catalin Marinas wrote:
    > > In the long run, I wouldn't mandate CROSS_COMPILE_COMPAT to always be
    > > set for the compat vDSO since with clang we could use the same compiler
    > > binary for both native and compat (with different flags). That's once we
    > > cleaned up the headers.
    >
    > But we'll still need it even with clang so that the relevant triple can be
    > passed to the --target option. The top-level Makefile already does this:
    >
    > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Makefile#n544

    That's not pulling the cross compiler out of a *config* (as this patch
    is proposing); rather from an env var.

    >
    > so I think we should do the same thing for the compat vdso as well, which
    > would allow us to remove this complexity by requiring that
    > CROSS_COMPILE_COMPAT identifies the cross-compiler to use in exactly the
    > same way as CROSS_COMPILE does.
    >
    > Am I missing something here?

    I think the second paragraph you wrote shows we're all in agreement,
    but I suspect you may be conflating *how* the toplevel Makefile knows
    we're doing a cross compile. It doesn't read a config, this patch
    would make it so a cross compiler is specified via config, Catalin
    asked "please no," I agree with Catalin (and I suspect you do too).
    --
    Thanks,
    ~Nick Desaulniers

    \
     
     \ /
      Last update: 2019-10-01 19:00    [W:3.671 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site