Messages in this thread | | | From | Logan Gunthorpe <> | Date | Wed, 9 Jan 2019 12:33:37 -0700 | Subject | Re: [PATCH v3 0/8] Fix breakage caused by the NTB multi-port patchset |
| |
On 2019-01-09 12:32 p.m., Dave Jiang wrote: >> I'm resending this because I've recently found out that the change we >> made to use the NTB struct device in DMA allocations is wrong and >> needs to be reverted. Turns out that, when running with an IOMMU, >> dma_alloc_coherent() will always fail if you pass it the NTB struct >> device. This is because the device has not been assigned an IOMMU >> group and the Intel IOMMU at least expect the devices to be on the PCI >> bus and be able to find a proper bus-dev-fn number through a struct >> pci device. Therefore, we must revert the change and I've changed >> patch 2 to do this and remove the no longer necessary DMA mask >> adjustments. > > For the revert, I think we should cc stable as well.
I agree it should go into stable too. But I thought the fixes tag would make that happen...
Logan
| |