Messages in this thread | | | Subject | Re: [PATCH v2 4/4] dt-bindings/irqchip/mbigen: add example of MBIGEN generate SPIs | From | Marc Zyngier <> | Date | Wed, 9 Jan 2019 10:48:27 +0000 |
| |
On 26/10/2018 08:51, Yang Yingliang wrote: > Now MBIGEN can support to generate SPIs by writing > GICD_SETSPIR. Add dt example to help document. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > .../interrupt-controller/hisilicon,mbigen-v2.txt | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/hisilicon,mbigen-v2.txt b/Documentation/devicetree/bindings/interrupt-controller/hisilicon,mbigen-v2.txt > index a6813a0..298c033 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/hisilicon,mbigen-v2.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/hisilicon,mbigen-v2.txt > @@ -10,7 +10,7 @@ Hisilicon designed mbigen to collect and generate interrupt. > > > Non-pci devices can connect to mbigen and generate the > -interrupt by writing ITS register. > +interrupt by writing GICD or ITS register. > > The mbigen chip and devices connect to mbigen have the following properties: > > @@ -64,6 +64,13 @@ Examples: > num-pins = <2>; > #interrupt-cells = <2>; > }; > + > + mbigen_spi_example:spi_example { > + interrupt-controller; > + msi-parent = <&gic>; > + num-pins = <2>; > + #interrupt-cells = <2>; > + }; > }; > > Devices connect to mbigen required properties: > @@ -82,3 +89,11 @@ Examples: > interrupts = <656 1>, > <657 1>; > }; > + > + spi_example: spi0@0 { > + compatible = "spi,example"; > + reg = <0 0 0 0>; > + interrupt-parent = <&mbigen_spi_example>; > + interrupts = <13 4>, > + <14 4>; > + }; >
I'd like an Ack of some sort from one of the DT maintainer. Rob?
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |