lkml.org 
[lkml]   [2019]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used
Digging up an old thread to point out I was wrong:

On Thu, Sep 27, 2018 at 1:08 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
> > This is not a million-little-commits problem; more like 2 drivers in
> > the whole tree have this problem.
> >
> > Note that this change that Nathan has DOES NOT need to applied to
> > every driver that uses MODULE_DEVICE_TABLE. Only when the struct has
> > no other references other than JUST being passed to
> > MODULE_DEVICE_TABLE() is this a problem. For an allyesconfig, I only
> > see 2 instances of this case in the whole tree:
> >
> > https://github.com/ClangBuiltLinux/linux/issues/169 <- this patch is addressing
> > https://github.com/ClangBuiltLinux/linux/issues/178 <- waiting on the
> > results of this patch
> >
> > If you're ok with this change to two drivers, then:
> > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

I just landed a fix for this in Clang
(https://reviews.llvm.org/rL350776) which will ship soon in Clang 8.
Sedat helped test this patch and reported that it removed 41
false-negative warnings
https://github.com/ClangBuiltLinux/linux/issues/232#issuecomment-440006399
--
Thanks,
~Nick Desaulniers

\
 
 \ /
  Last update: 2019-01-10 01:20    [W:0.053 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site