Messages in this thread | | | Date | Tue, 8 Jan 2019 10:29:59 -0800 | From | Matthew Wilcox <> | Subject | Re: [PATCH v4] mm: Create the new vm_fault_t type |
| |
On Wed, Jan 09, 2019 at 12:00:41AM +0530, Souptick Joarder wrote: > Page fault handlers are supposed to return VM_FAULT codes, > but some drivers/file systems mistakenly return error > numbers. Now that all drivers/file systems have been converted > to use the vm_fault_t return type, change the type definition > to no longer be compatible with 'int'. By making it an unsigned > int, the function prototype becomes incompatible with a function > which returns int. Sparse will detect any attempts to return a > value which is not a VM_FAULT code. > > VM_FAULT_SET_HINDEX and VM_FAULT_GET_HINDEX values are changed > to avoid conflict with other VM_FAULT codes. > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > Reviewed-by: William Kucharski <william.kucharski@oracle.com> > Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
Reviewed-by: Matthew Wilcox <willy@infradead.org>
| |