lkml.org 
[lkml]   [2019]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/4] phy: rockchip-inno-usb2: fix misspelling and kernel-doc documentation.
Date
Hi Enric,

Am Dienstag, 8. Januar 2019, 18:35:38 CET schrieb Enric Balletbo Serra:
> Hi Heiko and all,
>
> Missatge de Heiko Stuebner <heiko@sntech.de> del dia dc., 15 d’ag.
>
> 2018 a les 12:31:
> > Am Mittwoch, 15. August 2018, 11:59:31 CEST schrieb Enric Balletbo i
Serra:
> > > Fix the typo flase -> false and clean up the kernel-doc documentation in
> > > phy-rockchip-inno.usb2.c and fix the following warnings when
> > > documentation
> > > is built.
> > >
> > > :58: warning: missing initial short description
> > > :69: warning: cannot understand function prototype: 'enum
> > > :usb_chg_state '
> > > :97: warning: missing initial short description
> > > :136: warning: cannot understand function prototype: 'struct
> > > :rockchip_usb2phy_port_cfg ' 157: warning: cannot understand function
> > > :prototype: 'struct rockchip_usb2phy_cfg ' 163: warning: Function
> > > :parameter or member 'port_cfgs' not described in
> > > :'rockchip_usb2phy_cfg' 187: warning: cannot understand function
> > > :prototype: 'struct rockchip_usb2phy_port ' 204: warning: Function
> > > :parameter or member 'port_cfg' not described in
> > > :'rockchip_usb2phy_port' 207: warning: missing initial short
> > > :description
> > > :234: warning: Function parameter or member 'dev' not described in
> > > :'rockchip_usb2phy' 234: warning: Function parameter or member
> > > :'clk480m_hw' not described in 'rockchip_usb2phy'> >
> > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >
> > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> I included this patch in these series because I found the errors when
> I was working on this. But this patch doesn't really depend on the
> other patches and probably I should have had to send independently. I
> am planning to send a new version of these series excluding this
> patch. I think that the patch can be already picked (still applies
> cleanly and is fine to pick?) or do you prefer I resend?

I would resend it.

The patch is from august 2018, so I'd guess Kishon won't have it in his
inbox anymore, so a resend may be easier for everyone.


Heiko



\
 
 \ /
  Last update: 2019-01-08 18:39    [W:0.039 / U:2.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site