Messages in this thread | | | From | Thomas Hellstrom <> | Subject | Re: [PATCH 2/4] drm/vmwgfx: remove CONFIG_INTEL_IOMMU ifdefs | Date | Tue, 8 Jan 2019 10:55:16 +0000 |
| |
Hi,
On Sat, 2019-01-05 at 09:01 +0100, Christoph Hellwig wrote: ...
> intel_iommu_enabled is defined as always false for > !CONFIG_INTEL_IOMMU, > so remove the ifdefs around it. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > > -#if !defined(CONFIG_SWIOTLB) && !defined(CONFIG_INTEL_IOMMU) > - /* > - * No coherent page pool > - */ > - if (dev_priv->map_mode == vmw_dma_alloc_coherent) > - return -EINVAL; > -#endif >
Actually this hunk is incorrect, it tries to determine whether the TTM subsystem maintains a coherent page pool or not. If not, we can't use vmw_dma_alloc_coherent.
/Thomas
| |