lkml.org 
[lkml]   [2019]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 029/145] mtd: rawnand: omap2: Pass the parent of pdev to dma_request_chan()
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Boris Brezillon <boris.brezillon@bootlin.com>

    commit 9b432630e0150b777c423fdef6a7b8d17dfa70b6 upstream.

    Commit e1e6255c311b ("mtd: rawnand: omap2: convert driver to
    nand_scan()") moved part of the init code in the ->attach_chip hook
    and at the same time changed the struct device object passed to
    dma_request_chan() (&pdev->dev instead of pdev->dev.parent).

    Fixes: e1e6255c311b ("mtd: rawnand: omap2: convert driver to nand_scan()")
    Reported-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
    Tested-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mtd/nand/raw/omap2.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mtd/nand/raw/omap2.c
    +++ b/drivers/mtd/nand/raw/omap2.c
    @@ -1944,7 +1944,7 @@ static int omap_nand_attach_chip(struct
    case NAND_OMAP_PREFETCH_DMA:
    dma_cap_zero(mask);
    dma_cap_set(DMA_SLAVE, mask);
    - info->dma = dma_request_chan(dev, "rxtx");
    + info->dma = dma_request_chan(dev->parent, "rxtx");

    if (IS_ERR(info->dma)) {
    dev_err(dev, "DMA engine request failed\n");

    \
     
     \ /
      Last update: 2019-01-07 18:24    [W:6.301 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site