lkml.org 
[lkml]   [2019]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 037/145] ALSA: hda/tegra: clear pending irq handlers
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sameer Pujar <spujar@nvidia.com>

    commit 63d2a9ec310d8bcc955574220d4631aa55c1a80c upstream.

    Even after disabling interrupts on the module, it could be possible
    that irq handlers are still running. System hang is seen during
    suspend path. It was found that, there were pending writes on the
    HDA bus and clock was disabled by that time.

    Above mentioned issue is fixed by clearing any pending irq handlers
    before disabling clocks and returning from hda suspend.

    Suggested-by: Mohan Kumar <mkumard@nvidia.com>
    Suggested-by: Dara Ramesh <dramesh@nvidia.com>
    Signed-off-by: Sameer Pujar <spujar@nvidia.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/hda/hda_tegra.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/sound/pci/hda/hda_tegra.c
    +++ b/sound/pci/hda/hda_tegra.c
    @@ -233,10 +233,12 @@ static int hda_tegra_suspend(struct devi
    struct snd_card *card = dev_get_drvdata(dev);
    struct azx *chip = card->private_data;
    struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip);
    + struct hdac_bus *bus = azx_bus(chip);

    snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);

    azx_stop_chip(chip);
    + synchronize_irq(bus->irq);
    azx_enter_link_reset(chip);
    hda_tegra_disable_clocks(hda);


    \
     
     \ /
      Last update: 2019-01-07 18:24    [W:4.121 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site