Messages in this thread | | | From | David Howells <> | Subject | Re: Bug report: unaligned access with ext4 encryption | Date | Fri, 04 Jan 2019 17:28:02 +0000 |
| |
Eric Biggers <ebiggers@kernel.org> wrote:
> Hi Aaro, thanks for the bug report! I think you're on the right track; it makes > much more sense to have the keyrings subsystem store the payload with better > alignment, than to work around the 2-byte alignment in fscrypt. > > But how about '__aligned(__alignof__(u64))' instead? 4 bytes may not be enough. > > David, what do you think?
Does that even work?
Might be better to just insert 6 bytes of padding with a comment, but yes I agree that it's probably better to align it to at least machine word size.
David
| |