Messages in this thread | | | From | Max Filippov <> | Date | Thu, 3 Jan 2019 21:59:28 -0800 | Subject | Re: [PATCH 2/2] xtensa: generate uapi header and syscall table header files |
| |
On Thu, Jan 3, 2019 at 9:13 PM Firoz Khan <firoz.khan@linaro.org> wrote: > On Fri, 4 Jan 2019 at 04:14, Max Filippov <jcmvbkbc@gmail.com> wrote: > > > > > > +quiet_cmd_sysnr = SYSNR $@ > > > + cmd_sysnr = $(CONFIG_SHELL) '$(sysnr)' '$<' '$@' \ > > > + '$(sysnr_abis_$(basetarget))' \ > > > + '$(sysnr_pfx_$(basetarget))' \ > > > + '$(sysnr_offset_$(basetarget))' > > > + > > > > This patch seems to do more than it says in the description. > > Perhaps adding cmd_sysnr needs a separate patch with its > > own description? > > This build rule is unused now as I was tried to implement > something else. Hopefully I'll remove the the above change > in my v2.
Then maybe there's a way to move all these macros to a common makefile, as they seem to be fairly generic?
-- Thanks. -- Max
| |