lkml.org 
[lkml]   [2019]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] usb: chipidea: Grab the (legacy) USB PHY by phandle first
From
Date
Hello!

On 30.01.2019 19:30, Paul Kocialkowski wrote:

> According to the chipidea driver bindings, the USB PHY is specified via
> the "phys" phandle node. However, this only takes effect for USB PHYs
> that use the common PHY framework. For legacy USB PHYs, a simple lookup
> based on the USB PHY type is done instead.
>
> This does not play out well when more than USB PHY is registered, since

More than one?

> the first registered PHY matching the type will always be returned
> regardless of what the driver was bound to.
>
> Fix this by looking up the PHY based on the "phys" phandle node.
> Although generic PHYS and rather matched by their "phys-name" and not
> the "phys" phandle directly, there is no helper for similar lookup on
> legacy PHYs and it's probably not worth the effort to add it.
>
> When no legacy USB PHY is found by phandle, fallback to grabbing any
> registered USB2 PHY. This ensures backward compatibility if some users
> were actually relying on this mechanism.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
[...]

MBR, Sergei

\
 
 \ /
  Last update: 2019-01-31 08:49    [W:0.068 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site