lkml.org 
[lkml]   [2019]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 6/7] scsi: libsas: reset the phy address if discover failed
    From
    Date
    On 30/01/2019 08:24, Jason Yan wrote:
    > When we failed to discover the device, the phy address is still kept
    > in ex_phy. So when the next time we revalidate this phy the
    > address and device type is the same, it will be considered as flutter
    > and will not be discovered again. So the device will not be brought up.
    >
    > Fix this by reset the phy address to the initial value. Then
    > in the next revalidation the device will be discovered agian.

    Why fail to discover the device? I wonder in which scenario you have
    seen this, such that it is worth rediscovery.

    >
    > Tested-by: Chen Liangfei <chenliangfei1@huawei.com>
    > Signed-off-by: Jason Yan <yanaijie@huawei.com>
    > CC: Xiaofei Tan <tanxiaofei@huawei.com>
    > CC: John Garry <john.garry@huawei.com>
    > CC: Johannes Thumshirn <jthumshirn@suse.de>
    > CC: Ewan Milne <emilne@redhat.com>
    > CC: Christoph Hellwig <hch@lst.de>
    > CC: Tomas Henzl <thenzl@redhat.com>
    > CC: Dan Williams <dan.j.williams@intel.com>
    > CC: Hannes Reinecke <hare@suse.com>
    > ---
    > drivers/scsi/libsas/sas_expander.c | 7 +++++++
    > 1 file changed, 7 insertions(+)
    >
    > diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
    > index 6e56ebdc2148..e781941a7088 100644
    > --- a/drivers/scsi/libsas/sas_expander.c
    > +++ b/drivers/scsi/libsas/sas_expander.c
    > @@ -1100,6 +1100,13 @@ static int sas_ex_discover_dev(struct domain_device *dev, int phy_id)
    > i, SAS_ADDR(ex->ex_phy[i].attached_sas_addr));
    > }
    > }
    > + } else {
    > + /* if we failed to discover this device, we have to
    > + * reset the expander phy attached address so that we
    > + * will not treat the phy as flutter in the next
    > + * revalidation
    > + */
    > + memset(ex_phy->attached_sas_addr, 0, SAS_ADDR_SIZE);
    > }
    >
    > return res;
    >


    \
     
     \ /
      Last update: 2019-01-30 18:37    [W:6.382 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site