lkml.org 
[lkml]   [2019]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages
On Tue, Jan 29, 2019 at 11:03:56AM +0100, David Hildenbrand wrote:
> Not sure if encoding the -1 in the previous line is even better now that
> we have more space
>
> skip = (1 << compound_order(head)) - (page - head + 1);
>
> Looks good to me.
>
> > }

I would rather not do that.
For me looks a bit "subtle" why do we add up 1 after substracting page - head.
I think that doing "skip - 1" looks more clear, but I do not have a strong
opinion here.

--
Oscar Salvador
SUSE L3

\
 
 \ /
  Last update: 2019-01-30 08:52    [W:0.148 / U:21.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site