lkml.org 
[lkml]   [2019]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 7/9] usb: typec: Find the ports by also matching against the device node
On Wed, Jan 30, 2019 at 6:03 PM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> When the connections are defined in firmware, struct
> device_connection will have the fwnode member pointing to
> the device node (struct fwnode_handle) of the requested
> device, and the endpoint will not be used at all in that
> case.

> + /*
> + * FIXME: Check does the fwnode supports the requested SVID. If it does
> + * we need to return ERR_PTR(-PROBE_DEFER) when there is no device.
> + */
> + if (con->fwnode)
> + return class_find_device(typec_class, NULL, con->fwnode,
> + typec_port_fwnode_match);
> +
> + dev = class_find_device(typec_class, NULL, con->endpoint[ep],
> + typec_port_name_match);
> +
> + return dev ? dev : ERR_PTR(-EPROBE_DEFER);

Just to be clear, this one takes a reference on dev. Is it taken into account?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-01-30 17:54    [W:0.066 / U:3.576 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site