Messages in this thread | | | Date | Wed, 30 Jan 2019 16:29:56 +0100 | From | "" <> | Subject | Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier |
| |
On Wed, Jan 30, 2019 at 02:48:27PM +0000, Carlos Henrique Lima Melara wrote: > This patch fix the checkpatch.p1 warning: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > +/*
Why did you not fix up the indentation that was already mentioned?
> It includes the SPDX expression for GPL-2.0 and corrects the comment format to suit the kernel's coding style.
Always properly line-wrap your comments.
> > Signed-off-by: Carlos (Charles) Henrique Lima Melara <charlesmelara@outlook.com>
This needs to match your "From:" line.
thanks,
greg k-h
| |