lkml.org 
[lkml]   [2019]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3] livepatch: non static warnings fix
On Wed 2019-01-23 15:30:57, Miroslav Benes wrote:
> Hi,
>
> On Wed, 23 Jan 2019, Nicholas Mc Guire wrote:
>
> > Sparse reported warnings about non-static symbols. For the variables
> > a simple static attribute is fine - for the functions referenced by
> > livepatch via klp_func the symbol-names must be unmodified in the
> > symbol table and the patchable code has to be emitted. The resolution
> > is to attach __used attribute to the shared statically declared functions.
> >
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > Suggested-by: Joe Lawrence <joe.lawrence@redhat.com>
> > Link: https://lkml.org/lkml/2018/12/13/827
>
> could you reorder the tags and change Link: tag to
> https://lkml.kernel.org/r/<message_id> as asked for when we reviewed v2?

Just for record. My understanding is that the Link: tag usually points
to the mail with the final patch that was pushed.

It means that it is usually added by the maintainer and not the patch
sender.

Best Regards,
Petr

\
 
 \ /
  Last update: 2019-01-30 11:10    [W:0.040 / U:22.136 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site