Messages in this thread | | | Subject | Re: [PATCH][next] mtd: rawnand: meson:: make several functions static | From | Liang Yang <> | Date | Wed, 30 Jan 2019 13:20:56 +0800 |
| |
Hello Colin,
On 2019/1/29 20:44, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There are several functions that are local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings. > ok. thanks > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/mtd/nand/raw/meson_nand.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index b9c543d1054c..9557bd94dcd2 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -829,14 +829,14 @@ static int meson_nfc_read_oob(struct nand_chip *nand, int page) > return meson_nfc_read_page_hwecc(nand, NULL, 1, page); > } > > -bool meson_nfc_is_buffer_dma_safe(const void *buffer) > +static bool meson_nfc_is_buffer_dma_safe(const void *buffer) > { > if (virt_addr_valid(buffer) && (!object_is_on_stack(buffer))) > return true; > return false; > } > > -void * > +static void * > meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr) > { > if (WARN_ON(instr->type != NAND_OP_DATA_IN_INSTR)) > @@ -848,7 +848,7 @@ meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr) > return kzalloc(instr->ctx.data.len, GFP_KERNEL); > } > > -void > +static void > meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr, > void *buf) > { > @@ -863,7 +863,7 @@ meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr, > kfree(buf); > } > > -void * > +static void * > meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr) > { > if (WARN_ON(instr->type != NAND_OP_DATA_OUT_INSTR)) > @@ -876,7 +876,7 @@ meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr) > instr->ctx.data.len, GFP_KERNEL); > } > > -void > +static void > meson_nand_op_put_dma_safe_output_buf(const struct nand_op_instr *instr, > const void *buf) > { >
| |