lkml.org 
[lkml]   [2019]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] qcom: apr: Make apr callbacks in non-atomic context
On Thu 15 Nov 10:49 PST 2018, Srinivas Kandagatla wrote:

> APR communication with DSP is not atomic in nature.
> Its request-response type. Trying to pretend that these are atomic
> and invoking apr client callbacks directly under atomic/irq context has
> endless issues with soundcard. It makes more sense to convert these
> to nonatomic calls. This also coverts all the dais to be nonatomic.
>

Hi Srinivas,

Sorry for not looking at this before.

Are you sure that you're meeting the latency requirements of low-latency
audio with this change?

[..]
> @@ -303,6 +363,10 @@ static int apr_remove_device(struct device *dev, void *null)
>
> static void apr_remove(struct rpmsg_device *rpdev)
> {
> + struct apr *apr = dev_get_drvdata(&rpdev->dev);
> +
> + flush_workqueue(apr->rxwq);
> + destroy_workqueue(apr->rxwq);

The devices may still be communicating until you remove them on the next
line, wouldn't it make more sense to destroy the work queue after
removing the APR devices?

> device_for_each_child(&rpdev->dev, NULL, apr_remove_device);
> }

Regards,
Bjorn

\
 
 \ /
  Last update: 2019-01-31 02:18    [W:0.084 / U:0.244 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site