Messages in this thread | | | Subject | Re: [PATCH net-next] nfp: use struct_size() in kzalloc() | From | "Gustavo A. R. Silva" <> | Date | Wed, 30 Jan 2019 18:57:46 -0600 |
| |
On 1/30/19 6:52 PM, Jakub Kicinski wrote: > On Wed, 30 Jan 2019 18:38:59 -0600, Gustavo A. R. Silva wrote: >> One of the more common cases of allocation size calculations is finding >> the size of a structure that has a zero-sized array at the end, along >> with memory for some number of elements for that array. For example: >> >> struct foo { >> int stuff; >> struct boo entry[]; >> }; >> >> instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL); >> >> Instead of leaving these open-coded and prone to type mistakes, we can >> now use the new struct_size() helper: >> >> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); >> >> This code was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com> >
Thanks, Jakub.
-- Gustavo
| |