[lkml]   [2019]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[GIT PULL][PATCH] sh: ftrace: Fix missing parenthesis in WARN_ON()


It appears that the zero-day bot did find a bug in my sh build.
And that I didn't have the bad code in my config file when I
cross compiled it, although there are a few other errors in sh
that makes it not build for me, I missed that I added one more.

I replaced WARN_ON(current->curr_ret_stack) with
WARN_ON(ftrace_graph_get_ret_stack(current, 1) where it should be:
WARN_ON(ftrace_graph_get_ret_stack(current, 1))

Please pull the latest trace-v4.21-1 tree, which can be found at:


Tag SHA1: 0695bd08e48f3e80e08afb6ea256639a4e81624c
Head SHA1: dc56367cb5dbf9d593e4b12373489df9a7edb72c

Steven Rostedt (VMware) (1):
sh: ftrace: Fix missing parenthesis in WARN_ON()

arch/sh/kernel/dwarf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit dc56367cb5dbf9d593e4b12373489df9a7edb72c
Author: Steven Rostedt (VMware) <>
Date: Thu Jan 3 22:02:39 2019 -0500

sh: ftrace: Fix missing parenthesis in WARN_ON()

Adding a function inside a WARN_ON() didn't close the WARN_ON parathesis.

Cc: Yoshinori Sato <>
Cc: Rich Felker <>
Reported-by: kbuild test robot <>
Fixes: cec8d0e7f06e ("sh: ftrace: Use ftrace_graph_get_ret_stack() instead of curr_ret_stack")
Signed-off-by: Steven Rostedt (VMware) <>

diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c
index df0fd6efe758..00622598a245 100644
--- a/arch/sh/kernel/dwarf.c
+++ b/arch/sh/kernel/dwarf.c
@@ -619,7 +619,7 @@ struct dwarf_frame *dwarf_unwind_stack(unsigned long pc,
* than one patched return address on our stack,
* complain loudly.
- WARN_ON(ftrace_graph_get_ret_stack(current, 1);
+ WARN_ON(ftrace_graph_get_ret_stack(current, 1));

 \ /
  Last update: 2019-01-04 04:19    [W:0.044 / U:3.724 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site