lkml.org 
[lkml]   [2019]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] xtensa: remove nargs from __SYSCALL
On Wed, Jan 2, 2019 at 7:29 AM Firoz Khan <firoz.khan@linaro.org> wrote:
>
> The __SYSCALL macro's arguments are system call number,
> system call entry name and number of arguments for the
> system call.
>
> Argument- nargs in __SYSCALL(nr, entry, nargs) is neither
> calculated nor used anywhere. So it would be better to
> keep the implementaion as __SYSCALL(nr, entry). This will
> unifies the implementation with some other architetures
> too.

Perhaps "This will help unify the implementation with other architectures"?

> Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
> ---
> arch/xtensa/kernel/syscall.c | 2 +-
> arch/xtensa/kernel/syscalls/syscalltbl.sh | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/xtensa/kernel/syscall.c b/arch/xtensa/kernel/syscall.c
> index 2c415fc..0665339 100644
> --- a/arch/xtensa/kernel/syscall.c
> +++ b/arch/xtensa/kernel/syscall.c
> @@ -31,7 +31,7 @@
> syscall_t sys_call_table[__NR_syscalls] /* FIXME __cacheline_aligned */= {
> [0 ... __NR_syscalls - 1] = (syscall_t)&sys_ni_syscall,
>
> -#define __SYSCALL(nr, entry, nargs)[nr] = (syscall_t)entry,
> +#define __SYSCALL(nr, entry)[nr] = (syscall_t)entry,
> #include <asm/syscall_table.h>
> #undef __SYSCALL
> };
> diff --git a/arch/xtensa/kernel/syscalls/syscalltbl.sh b/arch/xtensa/kernel/syscalls/syscalltbl.sh
> index 85d78d9..904b8e6 100644
> --- a/arch/xtensa/kernel/syscalls/syscalltbl.sh
> +++ b/arch/xtensa/kernel/syscalls/syscalltbl.sh
> @@ -13,10 +13,10 @@ emit() {
> t_entry="$3"
>
> while [ $t_nxt -lt $t_nr ]; do
> - printf "__SYSCALL(%s, sys_ni_syscall, )\n" "${t_nxt}"
> + printf "__SYSCALL(%s,sys_ni_syscall)\n" "${t_nxt}"

Please add space after the comma.

> t_nxt=$((t_nxt+1))
> done
> - printf "__SYSCALL(%s, %s, )\n" "${t_nxt}" "${t_entry}"
> + printf "__SYSCALL(%s,%s)\n" "${t_nxt}" "${t_entry}"

Ditto.

> }
>
> grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
> --
> 1.9.1

With the above changes:
Acked-by: Max Filippov <jcmvbkbc@gmail.com>

--
Thanks.
-- Max

\
 
 \ /
  Last update: 2019-01-04 03:59    [W:0.051 / U:11.384 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site