lkml.org 
[lkml]   [2019]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/2] xtensa: generate uapi header and syscall table header files
    Hi Firoz,

    On Wed, Jan 2, 2019 at 7:29 AM Firoz Khan <firoz.khan@linaro.org> wrote:
    > Unified system call table generation script must be run to
    > generate unistd_32.h and syscall_table.h files. This patch
    > will have changes which will invokes the script.
    >
    > This patch will generate unistd_32.h and syscall_table.h
    > files by the syscall table generation script invoked by
    > xtensa/Makefile and the generated files against the removed
    > files must be identical.
    >
    > The generated uapi header file will be included in uapi/-
    > asm/unistd.h and generated system call table header file
    > will be included by kernel/syscall.c file.
    >
    > Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
    > ---
    > arch/xtensa/kernel/syscalls/Makefile | 11 ++++++++--
    > arch/xtensa/kernel/syscalls/syscallhdr.sh | 36 -------------------------------
    > arch/xtensa/kernel/syscalls/syscalltbl.sh | 32 ---------------------------
    > 3 files changed, 9 insertions(+), 70 deletions(-)
    > delete mode 100644 arch/xtensa/kernel/syscalls/syscallhdr.sh
    > delete mode 100644 arch/xtensa/kernel/syscalls/syscalltbl.sh
    >
    > diff --git a/arch/xtensa/kernel/syscalls/Makefile b/arch/xtensa/kernel/syscalls/Makefile
    > index 659faef..75c7421 100644
    > --- a/arch/xtensa/kernel/syscalls/Makefile
    > +++ b/arch/xtensa/kernel/syscalls/Makefile
    > @@ -6,8 +6,9 @@ _dummy := $(shell [ -d '$(uapi)' ] || mkdir -p '$(uapi)') \
    > $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)')
    >
    > syscall := $(srctree)/$(src)/syscall.tbl
    > -syshdr := $(srctree)/$(src)/syscallhdr.sh
    > -systbl := $(srctree)/$(src)/syscalltbl.sh
    > +syshdr := $(srctree)/scripts/syscallhdr.sh
    > +sysnr := $(srctree)/scripts/syscallnr.sh
    > +systbl := $(srctree)/scripts/syscalltbl.sh
    >
    > quiet_cmd_syshdr = SYSHDR $@
    > cmd_syshdr = $(CONFIG_SHELL) '$(syshdr)' '$<' '$@' \
    > @@ -15,6 +16,12 @@ quiet_cmd_syshdr = SYSHDR $@
    > '$(syshdr_pfx_$(basetarget))' \
    > '$(syshdr_offset_$(basetarget))'
    >
    > +quiet_cmd_sysnr = SYSNR $@
    > + cmd_sysnr = $(CONFIG_SHELL) '$(sysnr)' '$<' '$@' \
    > + '$(sysnr_abis_$(basetarget))' \
    > + '$(sysnr_pfx_$(basetarget))' \
    > + '$(sysnr_offset_$(basetarget))'
    > +

    This patch seems to do more than it says in the description.
    Perhaps adding cmd_sysnr needs a separate patch with its
    own description?

    --
    Thanks.
    -- Max

    \
     
     \ /
      Last update: 2019-01-03 23:45    [W:4.305 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site