[lkml]   [2019]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [RFC v4 0/3] pstore/rom: new support logger for block devices
I'm curious why you call this "pstore/rom" rather than the more descriptive "pstore/block".

It looks to be a really good idea.

I think you need to document how the "write" function for the block device must be written.
Since pstore calls this at "panic" time, the write path:

+ Cannot allocate any memory
+ Must be polled, not interrupt driven
+ Cannot take any locks that may be held by regular code
+ ... perhaps other restrictions that I can't think of right now

The memory allocation restriction is likely easy to get around. Just allocate anything
you need at pstore "init" time rather than waiting until the panic.


 \ /
  Last update: 2019-01-03 18:19    [W:0.063 / U:10.536 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site