[lkml]   [2019]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] HISI LPC: Don't fail probe for unrecognised child devices
Currently for ACPI-based FW we fail the probe for an unrecognised child

However, there is FW in the field with LPC child devices having fake HIDs,
namely "IPI0002", which was an IPMI device invented to support the
initial out-of-tree LPC host driver, different from the final mainline

To provide compatibility support for these dodgy FWs, just discard the
unrecognised HIDs instead of failing the probe altogether.

Tested-by: Zengruan Ye <>
Signed-off-by: John Garry <>

diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
index d5f8545..19d7b6f 100644
--- a/drivers/bus/hisi_lpc.c
+++ b/drivers/bus/hisi_lpc.c
@@ -522,10 +522,9 @@ static int hisi_lpc_acpi_probe(struct device *hostdev)

if (!found) {
- "could not find cell for child device (%s)\n",
+ "could not find cell for child device (%s), discarding\n",
- ret = -ENODEV;
- goto fail;
+ continue;

pdev = platform_device_alloc(cell->name, PLATFORM_DEVID_AUTO);
 \ /
  Last update: 2019-01-03 12:57    [W:0.050 / U:0.696 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site