Messages in this thread | | | Date | Tue, 29 Jan 2019 17:09:28 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/4] EDAC, skx_comm_edac: Separate common codes from the skx_edac driver |
| |
On Fri, Jan 25, 2019 at 11:58:59AM -0800, Tony Luck wrote: > From: Qiuxu Zhuo <qiuxu.zhuo@intel.com> > > Part of the skx_edac driver codes are also used for Intel 10nm server > EDAC driver. Carve out the common part from the skx_edac driver in > preparation to support both skx_edac driver and i10nm_edac driver. > > Co-developed-by: Tony Luck <tony.luck@intel.com> > Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com> > Signed-off-by: Tony Luck <tony.luck@intel.com> > --- > drivers/edac/skx_comm_edac.c | 693 +++++++++++++++++++++++++++++++++++ > drivers/edac/skx_comm_edac.h | 158 ++++++++ > 2 files changed, 851 insertions(+) > create mode 100644 drivers/edac/skx_comm_edac.c > create mode 100644 drivers/edac/skx_comm_edac.h
skx_common.[ch]
> diff --git a/drivers/edac/skx_comm_edac.h b/drivers/edac/skx_comm_edac.h > new file mode 100644 > index 000000000000..f7618a9cc0ae > --- /dev/null > +++ b/drivers/edac/skx_comm_edac.h > @@ -0,0 +1,158 @@ > +// SPDX-License-Identifier: GPL-2.0
If you guys would've used checkpatch, you would've seen:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #739: FILE: drivers/edac/skx_comm_edac.h:1: +// SPDX-License-Identifier: GPL-2.0
Needs to be /* ... */ in a header.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |