lkml.org 
[lkml]   [2019]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 66/68] f2fs: read page index before freeing
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Pan Bian <bianpan2016@163.com>

    commit 0ea295dd853e0879a9a30ab61f923c26be35b902 upstream.

    The function truncate_node frees the page with f2fs_put_page. However,
    the page index is read after that. So, the patch reads the index before
    freeing the page.

    Fixes: bf39c00a9a7f ("f2fs: drop obsolete node page when it is truncated")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Reviewed-by: Chao Yu <yuchao0@huawei.com>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/f2fs/node.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/fs/f2fs/node.c
    +++ b/fs/f2fs/node.c
    @@ -694,6 +694,7 @@ static void truncate_node(struct dnode_o
    {
    struct f2fs_sb_info *sbi = F2FS_I_SB(dn->inode);
    struct node_info ni;
    + pgoff_t index;

    get_node_info(sbi, dn->nid, &ni);
    f2fs_bug_on(sbi, ni.blk_addr == NULL_ADDR);
    @@ -712,10 +713,11 @@ static void truncate_node(struct dnode_o
    clear_node_page_dirty(dn->node_page);
    set_sbi_flag(sbi, SBI_IS_DIRTY);

    + index = dn->node_page->index;
    f2fs_put_page(dn->node_page, 1);

    invalidate_mapping_pages(NODE_MAPPING(sbi),
    - dn->node_page->index, dn->node_page->index);
    + index, index);

    dn->node_page = NULL;
    trace_f2fs_truncate_node(dn->inode, dn->nid, ni.blk_addr);

    \
     
     \ /
      Last update: 2019-01-29 12:56    [W:6.387 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site