Messages in this thread | | | Subject | RE: [PATCH 3/3] devfreq: add mediatek cci devfreq | From | MyungJoo Ham <> | Date | Tue, 29 Jan 2019 17:17:50 +0900 |
| |
>From: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com> > >For big/little cpu cluster architecture, >not only CPU frequency, but CCI frequency will also affect performance. > >Little cores and cci share the same buck in Mediatek mt8183 IC, >so we add a CCI devfreq which will get notification when buck voltage >is changed, then CCI devfreq can set cci frequency as high as possible. > >Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
Please correct the coding style first in the .c file.
- empty last line? - inconsistent indentation (line26? match the first lines for all variable declarations OR don't match them at all) - Need proper boilerplate and try to comply with C89.
Cheers, MyungJoo
| |