lkml.org 
[lkml]   [2019]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/nouveau: fix missing break in switch statement
From
Date


On 10/8/18 3:47 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The NOUVEAU_GETPARAM_PCI_DEVICE case is missing a break statement and falls
> through to the following NOUVEAU_GETPARAM_BUS_TYPE case and may end up
> re-assigning the getparam->value to an undesired value. Fix this by adding
> in the missing break.
>
> Detected by CoverityScan, CID#1460507 ("Missing break in switch")
>
> Fixes: 359088d5b8ec ("drm/nouveau: remove trivial cases of nvxx_device() usage")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Friendly ping:

Who can take this?

Thanks
--
Gustavo

> ---
> drivers/gpu/drm/nouveau/nouveau_abi16.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c
> index e67a471331b5..6ec745873bc5 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c
> @@ -214,6 +214,7 @@ nouveau_abi16_ioctl_getparam(ABI16_IOCTL_ARGS)
> WARN_ON(1);
> break;
> }
> + break;
> case NOUVEAU_GETPARAM_FB_SIZE:
> getparam->value = drm->gem.vram_available;
> break;
>

\
 
 \ /
  Last update: 2019-01-29 21:51    [W:0.041 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site