Messages in this thread | | | Date | Tue, 29 Jan 2019 22:34:22 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v8 5/7] tpm: move tpm_chip definition to include/linux/tpm.h |
| |
On Thu, Jan 24, 2019 at 04:49:08PM +0100, Roberto Sassu wrote: > -enum tpm_const { > - TPM_MINOR = 224, /* officially assigned */ > - TPM_BUFSIZE = 4096, > - TPM_NUM_DEVICES = 65536, > - TPM_RETRY = 50, /* 5 seconds */ > - TPM_NUM_EVENT_LOG_FILES = 3, > -};
Here using enum has been a bad idea in the first place, as they don't relate in any meaningful way.
Replace the definition with the following in drivers/char/tpm/tpm.h:
#define TPM_MINOR 224 /* misc backwards compatibility */ #define TPM_BUFSIZE 4096 #define TPM_NUM_DEVICES 65536 #define TPM_RETRY 5 /* seconds */
And only add this to include/linux/tpm.h:
#define TPM_NUM_EVENT_LOG_FILES 3
Otherwise, this looks good.
/Jarkko
| |