Messages in this thread | | | From | Brian Norris <> | Date | Tue, 29 Jan 2019 10:52:44 -0800 | Subject | Re: [PATCH] mwifiex: don't print error message on coex event |
| |
On Mon, Jan 28, 2019 at 7:43 AM Stefan Agner <stefan@agner.ch> wrote: > > The BT coex event is not an error condition. Don't print an error > message in this case. The same even in sta_event.c prints a > message using the debug level already.
For some reason, that one (and a handful of others) uses dev_dbg() instead of mwifiex_dbg() with an appropriate mask (e.g., EVENT). But mwifiex_dbg() seems preferable for consistency.
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Brian Norris <briannorris@chromium.org>
> --- > drivers/net/wireless/marvell/mwifiex/uap_event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/uap_event.c b/drivers/net/wireless/marvell/mwifiex/uap_event.c > index e86217a6b9ca..ca759d9c0253 100644 > --- a/drivers/net/wireless/marvell/mwifiex/uap_event.c > +++ b/drivers/net/wireless/marvell/mwifiex/uap_event.c > @@ -300,7 +300,7 @@ int mwifiex_process_uap_event(struct mwifiex_private *priv) > mwifiex_11h_handle_radar_detected(priv, adapter->event_skb); > break; > case EVENT_BT_COEX_WLAN_PARA_CHANGE: > - dev_err(adapter->dev, "EVENT: BT coex wlan param update\n"); > + mwifiex_dbg(adapter, EVENT, "event: BT coex wlan param update\n"); > mwifiex_bt_coex_wlan_param_update_event(priv, > adapter->event_skb); > break; > -- > 2.20.1 >
| |