lkml.org 
[lkml]   [2019]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 14/14] clk: meson: rework and clean drivers dependencies
    From
    Date
    Quoting Jerome Brunet (2019-01-28 10:04:30)
    > Initially, the meson clock directory only hosted 2 controllers drivers,
    > for meson8 and gxbb. At the time, both used the same set of clock drivers
    > so managing the dependencies was not a big concern.
    >
    > Since this ancient time, entropy did its job, controllers with different
    > requirement and specific clock drivers have been added. Unfortunately, we
    > did not do a great job at managing the dependencies between the
    > controllers and the different clock drivers. Some drivers, such as
    > clk-phase or vid-pll-div, are compiled even if they are useless on the
    > target (meson8). As we are adding new controllers, we need to be able to
    > pick a driver w/o pulling the whole thing.
    >
    > The patch aims to clean things up by:
    > * providing a dedicated CONFIG_ for each clock drivers
    > * allowing clock drivers to be compiled as a modules, if possible
    > * stating explicitly which drivers are required by each controller.
    >
    > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

    Sounds good to me.

    > diff --git a/drivers/clk/meson/Makefile b/drivers/clk/meson/Makefile
    > index 2b9490dd9878..8baec10a49a1 100644
    > --- a/drivers/clk/meson/Makefile
    > +++ b/drivers/clk/meson/Makefile
    > @@ -2,12 +2,17 @@
    > # Makefile for Meson specific clk
    > #
    >

    Add a comment here that these are all the clk library parts or something
    like that?

    > -obj-$(CONFIG_COMMON_CLK_AMLOGIC) += clk-pll.o clk-mpll.o clk-phase.o vid-pll-div.o
    > -obj-$(CONFIG_COMMON_CLK_AMLOGIC) += clk-input.o clk-dualdiv.o
    > -obj-$(CONFIG_COMMON_CLK_AMLOGIC_AUDIO) += sclk-div.o
    > -obj-$(CONFIG_COMMON_CLK_MESON_AO) += meson-aoclk.o
    > +obj-$(CONFIG_COMMON_CLK_MESON_INPUT) += clk-input.o
    > +obj-$(CONFIG_COMMON_CLK_MESON_REGMAP) += clk-regmap.o
    > +obj-$(CONFIG_COMMON_CLK_MESON_DUALDIV) += clk-dualdiv.o
    > +obj-$(CONFIG_COMMON_CLK_MESON_MPLL) += clk-mpll.o
    > +obj-$(CONFIG_COMMON_CLK_MESON_PHASE) += clk-phase.o
    > +obj-$(CONFIG_COMMON_CLK_MESON_PLL) += clk-pll.o
    > +obj-$(CONFIG_COMMON_CLK_MESON_SCLK_DIV) += sclk-div.o
    > +obj-$(CONFIG_COMMON_CLK_MESON_VID_PLL_DIV) += vid-pll-div.o
    > +obj-$(CONFIG_COMMON_CLK_MESON_AO_CLKC) += meson-aoclk.o
    > +

    And maybe add a comment here indicating that SoC drivers go below?

    > obj-$(CONFIG_COMMON_CLK_MESON8B) += meson8b.o
    > -obj-$(CONFIG_COMMON_CLK_GXBB) += gxbb.o gxbb-aoclk.o
    > -obj-$(CONFIG_COMMON_CLK_AXG) += axg.o axg-aoclk.o
    > -obj-$(CONFIG_COMMON_CLK_AXG_AUDIO) += axg-audio.o
    > -obj-$(CONFIG_COMMON_CLK_REGMAP_MESON) += clk-regmap.o
    > +obj-$(CONFIG_COMMON_CLK_GXBB) += gxbb.o gxbb-aoclk.o
    > +obj-$(CONFIG_COMMON_CLK_AXG) += axg.o axg-aoclk.o
    > +obj-$(CONFIG_COMMON_CLK_AXG_AUDIO) += axg-audio.o

    And sort them by config name alphanumerically?

    \
     
     \ /
      Last update: 2019-01-29 19:09    [W:4.500 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site