lkml.org 
[lkml]   [2019]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.20 212/304] perf header: Fix up argument to ctime()
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    [ Upstream commit 0afcf29bab35d3785204cd9bd51693b231ad7181 ]

    Reducing this noise when cross building to the Android NDK:

    util/header.c: In function 'perf_header__fprintf_info':
    util/header.c:2710:45: warning: pointer targets in passing argument 1 of 'ctime' differ in signedness [-Wpointer-sign]
    fprintf(fp, "# captured on : %s", ctime(&st.st_ctime));
    ^
    In file included from util/../perf.h:5:0,
    from util/evlist.h:11,
    from util/header.c:22:
    /opt/android-ndk-r15c/platforms/android-26/arch-arm/usr/include/time.h:81:14: note: expected 'const time_t *' but argument is of type 'long unsigned int *'
    extern char* ctime(const time_t*) __LIBC_ABI_PUBLIC__;
    ^

    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: https://lkml.kernel.org/n/tip-6bz74zp080yhmtiwb36enso9@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/perf/util/header.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
    index 13a2251a37c5..05f40bb51a88 100644
    --- a/tools/perf/util/header.c
    +++ b/tools/perf/util/header.c
    @@ -2659,6 +2659,7 @@ int perf_header__fprintf_info(struct perf_session *session, FILE *fp, bool full)
    struct perf_header *header = &session->header;
    int fd = perf_data__fd(session->data);
    struct stat st;
    + time_t stctime;
    int ret, bit;

    hd.fp = fp;
    @@ -2668,7 +2669,8 @@ int perf_header__fprintf_info(struct perf_session *session, FILE *fp, bool full)
    if (ret == -1)
    return -1;

    - fprintf(fp, "# captured on : %s", ctime(&st.st_ctime));
    + stctime = st.st_ctime;
    + fprintf(fp, "# captured on : %s", ctime(&stctime));

    fprintf(fp, "# header version : %u\n", header->version);
    fprintf(fp, "# data offset : %" PRIu64 "\n", header->data_offset);
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-01-28 16:54    [W:4.039 / U:0.896 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site