lkml.org 
[lkml]   [2019]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mtd: nand: fix kernel-doc warnings
    On Sun, 27 Jan 2019 18:21:42 -0800
    Randy Dunlap <rdunlap@infradead.org> wrote:

    > From: Randy Dunlap <rdunlap@infradead.org>
    >
    > Fix kernel-doc warnings in drivers/mtd/nand/raw:
    >
    > ../drivers/mtd/nand/raw/nand_base.c:420: warning: Function parameter or member 'chip' not described in 'nand_fill_oob'
    > ../drivers/mtd/nand/raw/nand_bbt.c:173: warning: Function parameter or member 'this' not described in 'read_bbt'
    > ../drivers/mtd/nand/raw/nand_bbt.c:173: warning: Excess function parameter 'chip' description in 'read_bbt'
    >
    > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    > Cc: Boris Brezillon <boris.brezillon@bootlin.com>
    > Cc: Miquel Raynal <miquel.raynal@bootlin.com>
    > Cc: Richard Weinberger <richard@nod.at>
    > Cc: linux-mtd@lists.infradead.org
    > ---
    > Do you want Fixes: tags for these:
    >
    > Fixes: 0813621ba898a ("mtd: rawnand: Stop passing mtd_info objects to internal functions")

    Will add this one.

    > Fixes: 99f3351a6d6e0 ("mtd: rawnand: Reorganize code to avoid forward declarations")

    Well, I don't think that one is responsible for the new warnings since
    all I did was moving code around.

    Thanks,

    Boris

    >
    > drivers/mtd/nand/raw/nand_base.c | 1 +
    > drivers/mtd/nand/raw/nand_bbt.c | 2 +-
    > 2 files changed, 2 insertions(+), 1 deletion(-)
    >
    > --- lnx-50-rc4.orig/drivers/mtd/nand/raw/nand_base.c
    > +++ lnx-50-rc4/drivers/mtd/nand/raw/nand_base.c
    > @@ -410,6 +410,7 @@ static int nand_check_wp(struct nand_chi
    >
    > /**
    > * nand_fill_oob - [INTERN] Transfer client buffer to oob
    > + * @chip: NAND chip object
    > * @oob: oob data buffer
    > * @len: oob data write length
    > * @ops: oob ops structure
    > --- lnx-50-rc4.orig/drivers/mtd/nand/raw/nand_bbt.c
    > +++ lnx-50-rc4/drivers/mtd/nand/raw/nand_bbt.c
    > @@ -158,7 +158,7 @@ static u32 add_marker_len(struct nand_bb
    >
    > /**
    > * read_bbt - [GENERIC] Read the bad block table starting from page
    > - * @chip: NAND chip object
    > + * @this: NAND chip object
    > * @buf: temporary buffer
    > * @page: the starting page
    > * @num: the number of bbt descriptors to read
    >
    >
    >
    > ______________________________________________________
    > Linux MTD discussion mailing list
    > http://lists.infradead.org/mailman/listinfo/linux-mtd/

    \
     
     \ /
      Last update: 2019-01-28 10:44    [W:7.631 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site