Messages in this thread | | | Subject | Re: [PATCH] drm/amd/powerplay: Fix missing break in switch | From | "Gustavo A. R. Silva" <> | Date | Mon, 28 Jan 2019 12:23:16 -0600 |
| |
On 1/28/19 10:19 AM, Alex Deucher wrote: > On Fri, Jan 25, 2019 at 5:31 PM Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> >> Add missing break statement in order to prevent the code from falling >> through to the default case. >> >> The resoning for this is that pclk_vol_table is an automatic variable. >> So, it makes no sense to update it just before falling through to the >> default case and return -EINVAL. >> >> This bug was found thanks to the ongoing efforts to enabling >> -Wimplicit-fallthrough. >> >> Fixes: cd70f3d6e3fa ("drm/amd/powerplay: PP/DAL interface changes for dynamic clock switch") >> Cc: stable@vger.kernel.org >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Applied. Thanks! >
Great. :)
Thanks, Alex. -- Gustavo
| |