lkml.org 
[lkml]   [2019]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 011/107] powerpc/pseries: add of_node_put() in dlpar_detach_node()
    Date
    From: Frank Rowand <frank.rowand@sony.com>

    [ Upstream commit 5b3f5c408d8cc59b87e47f1ab9803dbd006e4a91 ]

    The previous commit, "of: overlay: add missing of_node_get() in
    __of_attach_node_sysfs" added a missing of_node_get() to
    __of_attach_node_sysfs(). This results in a refcount imbalance
    for nodes attached with dlpar_attach_node(). The calling sequence
    from dlpar_attach_node() to __of_attach_node_sysfs() is:

    dlpar_attach_node()
    of_attach_node()
    __of_attach_node_sysfs()

    For more detailed description of the node refcount, see
    commit 68baf692c435 ("powerpc/pseries: Fix of_node_put() underflow
    during DLPAR remove").

    Tested-by: Alan Tull <atull@kernel.org>
    Acked-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Frank Rowand <frank.rowand@sony.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/platforms/pseries/dlpar.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
    index 72ae2cdbcd6a..999b04819d69 100644
    --- a/arch/powerpc/platforms/pseries/dlpar.c
    +++ b/arch/powerpc/platforms/pseries/dlpar.c
    @@ -288,6 +288,8 @@ int dlpar_detach_node(struct device_node *dn)
    if (rc)
    return rc;

    + of_node_put(dn);
    +
    return 0;
    }

    --
    2.19.1
    \
     
     \ /
      Last update: 2019-01-28 17:51    [W:4.082 / U:0.772 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site