Messages in this thread | | | Date | Mon, 28 Jan 2019 08:58:19 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH v2 3/3] dt-bindings: iio: chemical: pms7003: add device tree support |
| |
On Sun, Jan 27, 2019 at 07:19:16PM +0100, Tomasz Duszynski wrote: > Add device tree support for Plantower PMS7003 particulate matter sensor. > > Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com> > --- > .../iio/chemical/plantower,pms7003.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt > > diff --git a/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt b/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt > new file mode 100644 > index 000000000000..e4c7f2fb1e30 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt > @@ -0,0 +1,19 @@ > +* Plantower PMS7003 particulate matter sensor > + > +Required properties: > +- compatible: must be "plantower,pms7003" > + > +Optional properties: > +- vcc-supply: phandle to the regulator that provides power to the sensor
Shouldn't this one be a required property?
> +- set-gpios: phandle to the GPIO connected to the SET line > +- reset-gpios: phandle to the GPIO connected to the RESET line > + > +Refer to serial/slave-device.txt for generic serial attached device bindings. > + > +Example: > + > +&uart0 { > + pms7003 {
The node name should be generic and reflect the functionality rather than model. Perhaps "pms" will do here.
> + compatible = "plantower,pms7003"; > + }; > +};
Johan
| |