Messages in this thread Patch in this message | | | From | Shuah Khan <> | Subject | [PATCH] usbip: Fix vep_free_request() null pointer checks on input args | Date | Fri, 25 Jan 2019 09:05:42 -0700 |
| |
Fix vep_free_request() to return when usb_ep and usb_request are null instead of calling WARN_ON.
Signed-off-by: Shuah Khan <shuah@kernel.org> --- drivers/usb/usbip/vudc_dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c index 1634d8698e15..a72c17ff1c6a 100644 --- a/drivers/usb/usbip/vudc_dev.c +++ b/drivers/usb/usbip/vudc_dev.c @@ -297,7 +297,8 @@ static void vep_free_request(struct usb_ep *_ep, struct usb_request *_req) { struct vrequest *req; - if (WARN_ON(!_ep || !_req)) + /* ep is always valid here - see usb_ep_free_request() */ + if (!_req) return; req = to_vrequest(_req); -- 2.17.1
| |