lkml.org 
[lkml]   [2019]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mtd: Annotate implicit fall through in nand_scan_tail
Hi Mathieu,

Mathieu Malaterre <malat@debian.org> wrote on Wed, 16 Jan 2019 20:50:04
+0100:

> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings (W=1).
>
> This commit removes the following warnings:
>
> drivers/mtd/nand/raw/nand_base.c:5556:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/mtd/nand/raw/nand_base.c:5575:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/mtd/nand/raw/nand_base.c:5613:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> drivers/mtd/nand/raw/nand_base.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index cca4b24d2ffa..da344c276088 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -5555,6 +5555,7 @@ static int nand_scan_tail(struct nand_chip *chip)
> }
> if (!ecc->read_page)
> ecc->read_page = nand_read_page_hwecc_oob_first;
> + /* fall through */
>
> case NAND_ECC_HW:
> /* Use standard hwecc read page function? */
> @@ -5574,6 +5575,7 @@ static int nand_scan_tail(struct nand_chip *chip)
> ecc->read_subpage = nand_read_subpage;
> if (!ecc->write_subpage && ecc->hwctl && ecc->calculate)
> ecc->write_subpage = nand_write_subpage_hwecc;
> + /* fall through */
>
> case NAND_ECC_HW_SYNDROME:
> if ((!ecc->calculate || !ecc->correct || !ecc->hwctl) &&
> @@ -5611,6 +5613,7 @@ static int nand_scan_tail(struct nand_chip *chip)
> ecc->size, mtd->writesize);
> ecc->mode = NAND_ECC_SOFT;
> ecc->algo = NAND_ECC_HAMMING;
> + /* fall through */
>
> case NAND_ECC_SOFT:
> ret = nand_set_ecc_soft_ops(chip);

Applied to nand/next with the subject prefix being "mtd: rawnand:"


Thanks,
Miquèl

\
 
 \ /
  Last update: 2019-01-25 13:37    [W:1.426 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site