lkml.org 
[lkml]   [2019]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 002/106] mlxsw: spectrum: Disable lag port TX before removing it
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jiri Pirko <jiri@mellanox.com>

    [ Upstream commit 8adbe212a159d9c78a90fca1d854f6e63452426b ]

    Make sure that lag port TX is disabled before mlxsw_sp_port_lag_leave()
    is called and prevent from possible EMAD error.

    Fixes: 0d65fc13042f ("mlxsw: spectrum: Implement LAG port join/leave")
    Signed-off-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: Ido Schimmel <idosch@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
    +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
    @@ -4635,12 +4635,15 @@ static int mlxsw_sp_netdevice_port_upper
    lower_dev,
    upper_dev);
    } else if (netif_is_lag_master(upper_dev)) {
    - if (info->linking)
    + if (info->linking) {
    err = mlxsw_sp_port_lag_join(mlxsw_sp_port,
    upper_dev);
    - else
    + } else {
    + mlxsw_sp_port_lag_tx_en_set(mlxsw_sp_port,
    + false);
    mlxsw_sp_port_lag_leave(mlxsw_sp_port,
    upper_dev);
    + }
    } else if (netif_is_ovs_master(upper_dev)) {
    if (info->linking)
    err = mlxsw_sp_port_ovs_join(mlxsw_sp_port);

    \
     
     \ /
      Last update: 2019-01-24 20:59    [W:4.230 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site