Messages in this thread | | | From | Brian Starkey <> | Subject | Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask | Date | Thu, 24 Jan 2019 16:52:44 +0000 |
| |
On Thu, Jan 24, 2019 at 10:12:10AM -0600, Andrew F. Davis wrote: > On 1/24/19 9:24 AM, Brian Starkey wrote:
[snip]
> > > > What do you think about renaming ion_allocation_data.unused to heap_id > > and adding a flag instead? It's adding cruft to a staging API, but it > > might soften the transition. The "old way" could get completely > > removed just before destaging. Just a thought. > > > > Sounds confusing, backwards compatibility in staging just doesn't seem > like the right thing to do. >
Well, fair enough. It's going to cause a bit of pain - libion could probably isolate most Android users. Laura patched that in AOSP last time around, but I don't know how that went (or how strongly Google feel about kernel ABI changes).
Thanks, -Brian
| |