lkml.org 
[lkml]   [2019]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] of: Make of_node_name_eq() case insensitive
Date
Since c32569e358ad ("regulator: Use of_node_name_eq for node name
comparisons") Vivien reported the mc13892-regulator complaining about
not being able to find regulators.

This is because prior to that commit we used of_node_cmp() to compare
the regulator array passed from mc13892_regulators down to
mc13xxx_parse_regulators_dt() and they are all defined in uppercase
letters by the MC13892_*_DEFINE* macros, whereas they are defined as
lowercase in the DTS.

Fix this by use strncasecmp() since that makes sure the comparison is
case insensitive like what of_node_cmp() did.

Reported-by: Vivien Didelot <vivien.didelot@gmail.com>
Fixes: c32569e358ad ("regulator: Use of_node_name_eq for node name comparisons")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/of/base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 5226e898476e..ff47c86277cb 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -66,7 +66,8 @@ bool of_node_name_eq(const struct device_node *np, const char *name)
node_name = kbasename(np->full_name);
len = strchrnul(node_name, '@') - node_name;

- return (strlen(name) == len) && (strncmp(node_name, name, len) == 0);
+ return (strlen(name) == len) &&
+ (strncasecmp(node_name, name, len) == 0);
}
EXPORT_SYMBOL(of_node_name_eq);

--
2.17.1
\
 
 \ /
  Last update: 2019-01-24 21:09    [W:0.067 / U:1.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site