Messages in this thread | | | Subject | Re: [PATCH] clk: imx: imx7ulp: use struct_size() in kzalloc() | From | "Gustavo A. R. Silva" <> | Date | Thu, 24 Jan 2019 13:39:10 -0600 |
| |
On 1/24/19 1:37 PM, Stephen Boyd wrote: > Quoting Gustavo A. R. Silva (2018-12-23 22:40:25) >> One of the more common cases of allocation size calculations is finding >> the size of a structure that has a zero-sized array at the end, along >> with memory for some number of elements for that array. For example: >> >> struct foo { >> int stuff; >> void *entry[]; >> }; >> >> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); >> >> Instead of leaving these open-coded and prone to type mistakes, we can >> now use the new struct_size() helper: >> >> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); >> >> This issue was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- > > Applied to clk-next >
Thanks, Stephen.
-- Gustavo
| |