lkml.org 
[lkml]   [2019]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: powerpc/spufs: use struct_size() in kmalloc()
    Date
    On Tue, 2019-01-08 at 18:37:20 UTC, "Gustavo A. R. Silva" wrote:
    > One of the more common cases of allocation size calculations is finding
    > the size of a structure that has a zero-sized array at the end, along
    > with memory for some number of elements for that array. For example:
    >
    > struct foo {
    > int stuff;
    > void *entry[];
    > };
    >
    > instance = kmalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
    >
    > Instead of leaving these open-coded and prone to type mistakes, we can
    > now use the new struct_size() helper:
    >
    > instance = kmalloc(struct_size(instance, entry, count), GFP_KERNEL);
    >
    > This code was detected with the help of Coccinelle.
    >
    > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

    Applied to powerpc next, thanks.

    https://git.kernel.org/powerpc/c/00def7130af8b3fad1bdef98429c94a6

    cheers

    \
     
     \ /
      Last update: 2019-01-24 04:41    [W:5.747 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site