Messages in this thread | | | Subject | Re: [PATCH net-next] bna: Mark expected switch fall-throughs | From | "Gustavo A. R. Silva" <> | Date | Wed, 23 Jan 2019 02:06:19 -0600 |
| |
On 1/23/19 2:03 AM, Sudarsana Reddy Kalluru wrote: > -----Original Message----- > From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com] > Sent: 23 January 2019 13:23 > To: Rasesh Mody <rasesh.mody@cavium.com>; Sudarsana Kalluru <sudarsana.kalluru@cavium.com>; Dept-GELinuxNICDev@cavium.com; David S. Miller <davem@davemloft.net> > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com> > Subject: [PATCH net-next] bna: Mark expected switch fall-throughs > > External Email > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/net/ethernet/brocade/bna/bfa_ioc.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c > index a36e38676640..cbc9175d74c5 100644 > --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c > +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c > @@ -788,9 +788,8 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event) > > case IOCPF_E_INITFAIL: > del_timer(&ioc->iocpf_timer); > - /* > - * !!! fall through !!! > - */ > + /* fall through */ > + > case IOCPF_E_TIMEOUT: > bfa_nw_ioc_hw_sem_release(ioc); > if (event == IOCPF_E_TIMEOUT) @@ -858,9 +857,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event) > > case IOCPF_E_FAIL: > del_timer(&ioc->iocpf_timer); > - /* > - * !!! fall through !!! > - */ > + /* fall through*/ > > case IOCPF_E_TIMEOUT: > bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL); > -- > 2.20.1 > > Acked-by: Sudarsana Kalluru <Sudarsana.Kalluru@cavium.com> >
Thanks, Sudarsana.
-- Gustavo
| |