lkml.org 
[lkml]   [2019]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 4/8] ASoC: wcd9335: add basic controls
On Thu, Jan 10, 2019 at 03:06:12PM +0000, Srinivas Kandagatla wrote:

> +static const char * const wcd9335_ear_pa_gain_text[] = {
> + "G_6_DB", "G_4P5_DB", "G_3_DB", "G_1P5_DB",
> + "G_0_DB", "G_M2P5_DB", "UNDEFINED", "G_M12_DB"
> +};

Gains should be controlled with Volume controls, not enums. Provide
information on the levels via TLV.

> +static const char * const rx_hph_mode_mux_text[] = {
> + "CLS_H_INVALID", "CLS_H_HIFI", "CLS_H_LP", "CLS_AB", "CLS_H_LOHIFI"
> +};

Is there a strong reason not to use more human readable strings here?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-01-22 19:53    [W:0.275 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site