Messages in this thread Patch in this message | | | From | Greg Kroah-Hartman <> | Subject | [PATCH] mm: kmemleak: no need to check return value of debugfs_create functions | Date | Tue, 22 Jan 2019 16:21:12 +0100 |
| |
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: linux-mm@kvack.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- mm/kmemleak.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/mm/kmemleak.c b/mm/kmemleak.c index f9d9dc250428..d45bc65db5fb 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -2124,14 +2124,9 @@ void __init kmemleak_init(void) */ static int __init kmemleak_late_init(void) { - struct dentry *dentry; - kmemleak_initialized = 1; - dentry = debugfs_create_file("kmemleak", 0644, NULL, NULL, - &kmemleak_fops); - if (!dentry) - pr_warn("Failed to create the debugfs kmemleak file\n"); + debugfs_create_file("kmemleak", 0644, NULL, NULL, &kmemleak_fops); if (kmemleak_error) { /* -- 2.20.1
| |