lkml.org 
[lkml]   [2019]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 11/16] sched/fair: Add uclamp support to energy_compute()
    On Tuesday 22 Jan 2019 at 15:01:37 (+0000), Patrick Bellasi wrote:
    > > I'm not saying it's useful, I'm saying userspace can decide to do that
    > > if it thinks it is a good idea. The default should be min_cap = 1024 for
    > > RT, no questions. But you _can_ change it at runtime if you want to.
    > > That's my point. And doing that basically provides the same behaviour as
    > > what we have right now in terms of EAS calculation (but it changes the
    > > freq selection obviously) which is why I'm not fundamentally opposed to
    > > your patch.
    >
    > Well, I think it's tricky to say whether the current or new approach
    > is better... it probably depends on the use-case.

    Agreed.

    > > So in short, I'm fine with the behavioural change, but please at least
    > > mention it somewhere :-)
    >
    > Anyway... agree, it's just that to add some documentation I need to
    > get what you are pointing out ;)
    >
    > Will come up with some additional text to be added to the changelog

    Sounds good.

    > Maybe we can add a more detailed explanation of the different
    > behaviors you can get in the EAS documentation which is coming to
    > mainline ?

    Yeah, if you feel like it, I guess that won't hurt :-)

    Thanks,
    Quentin

    \
     
     \ /
      Last update: 2019-01-22 16:14    [W:2.449 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site