Messages in this thread Patch in this message | | | From | Liu Jian <> | Subject | [PATCH v2 1/2] driver: uio: fix possible memory leak in __uio_register_device | Date | Wed, 23 Jan 2019 06:45:37 +0800 |
| |
'idev' is malloced in __uio_register_device() and leak free it before leaving from the uio_get_minor() error handing case, it will cause memory leak.
Fixes: a93e7b331568 ("uio: Prevent device destruction while fds are open") Signed-off-by: Liu Jian <liujian56@huawei.com> Reviewed-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz> --- drivers/uio/uio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index b4ae2d9..4d20220 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -941,8 +941,10 @@ int __uio_register_device(struct module *owner, atomic_set(&idev->event, 0); ret = uio_get_minor(idev); - if (ret) + if (ret) { + kfree(idev); return ret; + } idev->dev.devt = MKDEV(uio_major, idev->minor); idev->dev.class = &uio_class; -- 2.7.4
| |